This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Revert "Use std::sync::Condvar (#1732)" #9392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-pleasereview 🤓
|
It looks like @ordian signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
arkpar
previously approved these changes
Aug 21, 2018
andresilva
previously requested changes
Aug 21, 2018
| @@ -202,8 +202,8 @@ struct Verification<K: Kind> { | |||
| verifying: Mutex<VecDeque<Verifying<K>>>, | |||
| verified: Mutex<VecDeque<K::Verified>>, | |||
| bad: Mutex<HashSet<H256>>, | |||
| more_to_verify: SMutex<()>, | |||
| empty: SMutex<()>, | |||
| more_to_verify: Mutex<()>, | |||
There was a problem hiding this comment.
It seems like these locks were previously added so that they could be used with std::sync::Condvar. Previously the Condvar waited on unverified. Do you think we could remove these?
There was a problem hiding this comment.
Good question! Did that at first, but then I saw another PR using more_to_verify, and it wasn't obvious if they can be safely removed. Anyway, it seems to work w/o them, so I'm going to push another commit with the removal.
ordian
force-pushed
the
refactor/use-parking-lot-everywhere
branch
from
3c3c6f4
to
45dafaa
Compare
debris
added
A8-looksgood 🦄
|
wow, reverting a 26 months old PR 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1732. This would hopefully allow us to detect deadlocks via
--feature "deadlock_detection".parking_lot_corenow uses WaitOnAddress/WakeByAddress on Windows, so I guess the reason not to useparking_lot::Condvaris no longer relevant.