This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Don't error when Snapshot is aborted #9492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngotchac
added
A0-pleasereview 🤓
ordian
approved these changes
Sep 7, 2018
ethcore/src/snapshot/service.rs
Outdated
| self.feed_chunk_with_restoration(&mut restoration, hash, chunk, is_state) | ||
| match self.feed_chunk_with_restoration(&mut restoration, hash, chunk, is_state) { | ||
| Ok(()) => (), | ||
| Err(Error(SnapshotErrorKind::Snapshot(SnapshotError::RestorationAborted), _)) => (), |
There was a problem hiding this comment.
We could unify this cases with
Ok(()) |
Err(Error(<snip>)) => (),
ordian
added
A8-looksgood 🦄
dvdplm
approved these changes
Sep 10, 2018
ethcore/src/snapshot/service.rs
Outdated
| @@ -584,10 +585,19 @@ impl Service { | |||
| } | |||
|
|
|||
| /// Feed a chunk of either kind. no-op if no restoration or status is wrong. | |||
There was a problem hiding this comment.
Maybe update the doc-string to "Feed a chunk of either Block or Status kind. No-op if … …"?
andresilva
approved these changes
Sep 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would previously cause to delete all downloaded chunks if the snapshot was aborted while restoring a chunk.