Skip to content
This repository has been archived by the owner on Mar 25, 2019. It is now read-only.

Parity account selection doesn't look very good in extension #39

Closed
tomusdrw opened this issue Feb 2, 2017 · 4 comments
Closed

Parity account selection doesn't look very good in extension #39

tomusdrw opened this issue Feb 2, 2017 · 4 comments

Comments

@tomusdrw
Copy link
Contributor

tomusdrw commented Feb 2, 2017

@ngotchac could you have a look at this?

screenshot from 2017-02-02 10-42-38

We need to increase the size of closed iframe, and also fix some stuff in Parity.

It would be cool to test this stuff while developing Parity and also remove any styles overrides from parity-extension - maybe we should have better http://127.0.0.1:8180/embed.html page to test it?
@ngotchac
Copy link
Contributor

ngotchac commented Feb 2, 2017

@tomusdrw

This should be fixed with https://github.com/ethcore/parity/pull/4405

@tomusdrw
Copy link
Contributor Author

tomusdrw commented Feb 2, 2017 •
edited
Loading

Great! I think we still need to make the iframe a little bit bigger on our side.

@ngotchac
Copy link
Contributor

ngotchac commented Feb 6, 2017

@tomusdrw This is fixed right? From the latests merged PR, the iframe has full-width & height when open

@tomusdrw
Copy link
Contributor Author

tomusdrw commented Feb 6, 2017

Yup, ready to close.

@tomusdrw tomusdrw closed this as completed Feb 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomusdrw @ngotchac