Non-semver breaking change in v3.7.0

[prestwich]

Unsure what it was exactly, but ruint no longer compiles on 3.7.0

CI output here:
https://github.com/recmo/uint/actions/runs/12097285631/job/33732497498?pr=407

[bkchr]

Hey @prestwich, see #656 for the same discussion.

[prestwich]

Please check the CI logs above. This issue is not due to the MSRV change, but due to some sort of bounds change on either an assoc type requirement or on a blanket impl

[prestwich]

if you want to reproduce to assure yourself it's not MSRV related, you can compile on 1.80 as follows

cd ruint
cargo +1.80 update -p parity-scale-codec --precise 3.6.12 
cargo +1.80 c --features parity-scale-codec
cargo +1.80 update -p parity-scale-codec --precise 3.7.0
cargo +1.80 c --features parity-scale-codec

[bkchr]

Ahh sorry!

This is again this: recmo/uint#313

We forgot to revert the following changes on master: #545 🙈

@jsdw we should revert these changes on master, yank and release 3.7.1. Could you do this? Then at some point we should finally tackle 4.0.0.. 🙈

[jsdw]

I don't 100% follow the issue right now (just packing for flight etc so don't have time to look much): how about I yank 3.7.0 now and then can look to fix the rest and release 3.7.1 later?

[jsdw]

Ah I see, some PR to revert stuff was on a release branch instead of on master, so just need to apply that to master and we're good right? Maybe I have time lemme see

[jsdw]

Ok, I yanked 3.7.0 already and opened #663 which was my attempt at reverting said PRs on master and resolving the various conflicts, but I need to look over it in more detail to be confident it does the right thing. Need to get packing etc so I'll have a look later and we can release 3.7.1 when we're happy!

[StackOverflowExcept1on]

@jsdw can you also yank scale-codec-derive plz? it failed our CI: https://github.com/gear-tech/gear/actions/runs/12124067535/job/33800965532?pr=4340#step:14:1197
Cargo.lock contains 3.7.0 codec-derive and 3.6.12 codec

[jsdw]

Apologies; been travelling. That is yanked too now!

[prestwich]

thanks for this. I would like to support the breaking change in ruint when 4.0.0 releases. In the meantime I'm going to close this as stale: recmo/uint#313 and link back to this issue