This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
keep track of first block in blockchain #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis failure seems spurious (temp directory name collision?) |
|
|
||
| // binary search for the first block. | ||
| if raw_first.is_empty() { | ||
| let (mut f, mut hash) = (best_block_number, best_block_hash); |
There was a problem hiding this comment.
Why is it better than migration?
There was a problem hiding this comment.
seemed like it was a little small of a change for a migration, but maybe it's worthwhile.
There was a problem hiding this comment.
also, as this doesn't actually change the format of the database it would be strange to build a migration around it.
arkpar
added
A8-looksgood 🦄
gavofyork
added
A7-looksgoodcantmerge 🙄
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1936
All blocks in the inclusive range between the first and best block are guaranteed to be available for now.