This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Trie query recording and AccountDB factory for no mangling #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
changed the title
rphmeier
force-pushed
the
trie_record
branch
2 times, most recently
from
0b0a669
to
9b993d7
Compare
| @@ -51,10 +51,12 @@ impl StateProducer { | |||
| // modify existing accounts. | |||
| let mut accounts_to_modify: Vec<_> = { | |||
| let trie = TrieDB::new(&*db, &self.state_root).unwrap(); | |||
| trie.iter() | |||
| let regionck_bug = trie.iter() | |||
There was a problem hiding this comment.
knee-jerk reaction to working around a lifetime checker (regionck) error in rustc
There was a problem hiding this comment.
right - figured it might be something like that. shame it's buggy. if there's a tracking issue in the rust GH would be good to note it so can be fixed later.
|
a decent chunk of tests would be nice. |
gavofyork
added
A5-grumble 🔥
rphmeier
added
A0-pleasereview 🤓
|
The recorders are unit-tested, and I've just added a test which verifies the recording for a given trie. The next PR will create a more generic "prover" module which will create pseudorandom tries and verify proofs as well as idempotence. |
gavofyork
added
A8-looksgood 🦄
gavofyork
pushed a commit
that referenced
this pull request
Aug 24, 2016
* optionally use no mangling for accountdb * add the recorder module * get_recorded for tries, no virtual dispatch on readonly tries * add recording test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it was important to have the recorder stuff be statically dispatched so LLVM can inline out record calls to
NoOprecorders. This lead toTrieDBnot being object-safe any more so I put together an enum that the trie factory produces, which has the added bonus of reducing allocations and virtual dispatch for trie queries. Probably will extend that toTrieMutas well.