This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Stratum protocol general #1954
Merged
Stratum protocol general #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| use json_tcp_server::Server as JsonRpcServer; | ||
| use jsonrpc_core::{IoHandler, Params, IoDelegate, to_value, from_params}; | ||
| use std::sync::{Arc, RwLock, RwLockReadGuard}; |
There was a problem hiding this comment.
Could use parking_lot stuff here (use util::{RwLock, RwLockReadGuard})
arkpar
added
A8-looksgood 🦄
| @@ -179,6 +182,32 @@ impl PushWorkHandler for Stratum { | |||
| } | |||
| } | |||
|
|
|||
| lazy_static! { | |||
| static ref LOG_DUMMY: bool = { | |||
There was a problem hiding this comment.
I think either this or the lazy_static! invocation can be marked as #[cfg(test)] also
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to keep it small and reviewable, first part of protocol
at this point, it's pretty generic and just manages connected workers without pow-specific burden
it's up to higher level code to produce ethereum- / bitcoin- specific work packages for workers (via implementing
JobDispatcher)