This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Stratum IPC service #1959
Merged
Stratum IPC service #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
force-pushed
the
stratum-ipc-svc
branch
from
6a3692a
to
09d014d
Compare
|
|
||
| Options: | ||
| -l --logging LOGGING Specify the logging level. Must conform to the same | ||
| format as RUST_LOG. |
There was a problem hiding this comment.
tabs used in usage format string - should be spaces to ensure proper display on terminals.
gavofyork
added
A7-looksgoodcantmerge 🙄
|
lgtm. needs resolving though. |
Conflicts: parity/modules.rs parity/sync.rs
NikVolf
added
A8-looksgood 🦄
|
Changes Unknown when pulling 8fd684d on stratum-ipc-svc into * on master*. |
| ctrc_stop.store(true, Ordering::Relaxed); | ||
| }); | ||
| stop | ||
| } |
There was a problem hiding this comment.
should be a condvar so you don't have check the flag in a loop. probably for another PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes after #1954
also contains some DRYing of services boot code