This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Resolving URLs from contract #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tomusdrw
commented
Aug 19, 2016
tomusdrw
commented
- tiny fix for ethstore
added 13 commits
August 16, 2016 14:55
Conflicts: dapps/Cargo.toml dapps/src/apps/fetcher.rs dapps/src/apps/urlhint.rs dapps/src/lib.rs
tomusdrw
added
the
A3-inprogress ⏳
tomusdrw
removed
the
A3-inprogress ⏳
tomusdrw
force-pushed
the
dapps-urlhint
branch
from
1a0103a
to
6c3a012
Compare
added 2 commits
August 23, 2016 14:06
Conflicts: Cargo.lock
tomusdrw
force-pushed
the
dapps-urlhint
branch
from
4eb6588
to
0ab65fb
Compare
arkpar
added
A8-looksgood 🦄
| pub struct URLHintContract { | ||
| urlhint: Contract, | ||
| registrar: Contract, | ||
| client: Arc<Box<ContractClient>>, |
There was a problem hiding this comment.
why not just Arc<ContractClient>? Arc supports ?Sized types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.