Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixing uint serialization #2037

Merged
merged 1 commit into from
Sep 2, 2016
Merged

Fixing uint serialization #2037

merged 1 commit into from
Sep 2, 2016

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Sep 1, 2016

Closes #2032

When encoding QUANTITIES (integers, numbers): encode as hex, prefix with "0x", the most compact representation (slight exception: zero should be represented as "0x0")

https://github.com/ethereum/wiki/wiki/JSON-RPC#output-hex-values

@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Sep 1, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 85.384% when pulling 16eba37 on uint-ser into 9a5668f on master.

@keorn keorn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 2, 2016
@arkpar arkpar merged commit e2e6b11 into master Sep 2, 2016
@debris debris deleted the uint-ser branch September 2, 2016 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter identifier are not quantities
4 participants