-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
What's the benefit if the code is in a single repo anyway? |
It makes it easier to observe changes -- personally I hate to review a PR which is just a version bump + Cargo.lock hash change, because it almost always means that this "insubstantial" PR is just a mask for one which hasn't been properly reviewed. |
Oh, yeah - I agree. My point is why do we change references to Right now someone will make a change in |
Agree with @tomusdrw. Local references should use relative path. |
my reasoning behind using crates.io version was to ensure that changes actually get propagated to crates.io. if not, the crate might stagnate more than necessary. but i suppose the relative path is probably better |
14c0c24
to
9dbc49b
Compare
Another reason, which only just occurred to me now, is that you can't have local dependencies for published crates. As we may want to publish an |
Travis failure seems spurious, it's very strange. It can't fetch the source for https://github.com/ethcore/hyper for some reason. |
As
ethcore-bigint