This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixing evm-debug #2161
Merged
Fixing evm-debug #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
rphmeier
reviewed
Sep 19, 2016
| @@ -113,7 +113,7 @@ impl<'a> Finalize for Result<GasLeft<'a>> { | |||
| } | |||
|
|
|||
| /// Cost calculation type. For low-gas usage we calculate costs using usize instead of U256 | |||
| pub trait CostType: ops::Mul<Output=Self> + ops::Div<Output=Self> + ops::Add<Output=Self> + ops::Sub<Output=Self> + ops::Shr<usize, Output=Self> + ops::Shl<usize, Output=Self> + cmp::Ord + Sized + From<usize> + Copy { | |||
| pub trait CostType: ops::Mul<Output=Self> + ops::Div<Output=Self> + ops::Add<Output=Self> + ops::Sub<Output=Self> + ops::Shr<usize, Output=Self> + ops::Shl<usize, Output=Self> + cmp::Ord + Sized + From<usize> + Copy + fmt::Debug { | |||
There was a problem hiding this comment.
this line should be broken up
rphmeier
reviewed
Sep 19, 2016
| @@ -126,7 +126,7 @@ impl<Cost: CostType> evm::Evm for Interpreter<Cost> { | |||
| gasometer.current_gas = gasometer.current_gas - gas_cost; | |||
|
|
|||
| evm_debug!({ | |||
| println!("[0x{:x}][{}(0x{:x}) Gas: {:x}\n Gas Before: {:x}", | |||
| println!("[0x{:x}][{}(0x{:x}) Gas: {:?}\n Gas Before: {:?}", | |||
There was a problem hiding this comment.
should be one of the logging related macros (probably just debug!?)
There was a problem hiding this comment.
It's much easier to run/debug tests when there are printlns, cause logs are not initialized in tests. It's also a compilation feature, so when someone is compiling with it I guess you would expect the logs to be always printed.
rphmeier
added
A8-looksgood 🦄
|
There's a typo in the trait bounds here, needs fixing before merge. |
|
Shoot, I'm sorry, I haven't noticed that typo. Thanks! |
tomusdrw
added
A0-pleasereview 🤓
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.