This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
expose isConnected() from transport #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: js/src/api/transport/ws/ws.js
jacogr
added
A0-pleasereview 🤓
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
|
I looked over it and it looks okay, although I don't know enough about the jsapi to tell if things could be laid out better. |
gavofyork
added
A8-looksgood 🦄
gavofyork
pushed a commit
that referenced
this pull request
Sep 21, 2016
* add loggins & missing methods * Use Webscoket transport for API calls (built-in only) * style revert * debug comment removal * reconnection cleanups * proper send success * proper logging of error * simplify sending, error via onError (not try/catch) * fixup e2e tests * expose isConnected * expose isConnected * WS handles new RPCBase interface * merge conflicts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ethcore/parity/issues/2222
Allows us to show a status in the UI & additionally have the ability to actually have the status of the underlying connection - in the case of WS, the state may change based on tokens updated.
Additionally, also fixes the API E2E tests.