This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Separate path for ext code size #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
reviewed
Sep 22, 2016
| pub fn code(&self, a: &Address) -> Option<Bytes> { | ||
| self.ensure_cached(a, true, | ||
| |a| a.as_ref().map_or(None, |a|a.code().map(|x|x.to_vec()))) | ||
| |a| a.as_ref().map_or(None, |a| a.code().map(|x| x.to_vec()))) |
There was a problem hiding this comment.
tiny optimization here would be to save an allocation by having this return an Option<&[u8]> instead of reallocating.
There was a problem hiding this comment.
obviously doesn't help with the current network attack as no code actually gets loaded, but can't hurt.
gavofyork
added
A8-looksgood 🦄
|
tests fail. |
gavofyork
added
A7-looksgoodtestsfail 🤖
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.