Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Canonical state cache (master) #2311

Merged
merged 5 commits into from
Sep 27, 2016
Merged

Canonical state cache (master) #2311

merged 5 commits into from
Sep 27, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Sep 25, 2016

No description provided.

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 25, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 85.225% when pulling bd7e594 on state-cache-master into abcdc81 on master.

rphmeier
rphmeier reviewed Sep 26, 2016
View reviewed changes
ethcore/src/state_db.rs

/// Heap size used.
pub fn mem_used(&self) -> usize {
self.db.mem_used()
Copy link
Contributor

@rphmeier rphmeier Sep 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ account cache size?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRUCache does not support it. Placed a TODO for now

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Sep 27, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 85.257% when pulling 452db63 on state-cache-master into abcdc81 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 85.222% when pulling c18ec25 on state-cache-master into abcdc81 on master.

@arkpar
Copy link
Collaborator Author

arkpar commented Sep 27, 2016

Reviewed in #2308

@arkpar arkpar merged commit ad63780 into master Sep 27, 2016
@gavofyork gavofyork added A8-backport 🕸 Pull request is already reviewed well in another branch. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 27, 2016
jacogr added a commit that referenced this pull request Sep 29, 2016
@jacogr
Merge branch 'master' into js
50adb8a 
* master:
  Fixing Delegate Call in JIT (#2378)
  Prioritizing re-imported transactions (#2372)
  Revert #2172, pretty much. (#2387)
  correct sync memory usage calculation (#2385)
  Update gitlab-ci
  Fix the traceAddress field in transaction traces. (#2373)
  Removing extras data from retracted blocks. (#2375)
  fixed #2263, geth keys with ciphertext shorter than 32 bytes (#2318)
  Expanse compatibility (#2369)
  Specify column cache sizes explicitly; default fallback of 2MB (#2358)
  Canonical state cache (master) (#2311)
  make block queue into a more generic verification queue and fix block heap size calculation (#2095)
  Hash Content RPC method (#2355)
  Reorder transaction_by_hash to favour canon search (#2332)
  DIV optimization (#2327)
  Error when deserializing invalid hex (#2339)
  Changed http:// to https:// on some links (#2349)
  add a test
  fix migration system, better errors

# Conflicts:
#	.gitlab-ci.yml
@arkpar arkpar deleted the state-cache-master branch October 3, 2016 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rphmeier rphmeier rphmeier left review comments

Assignees
No one assigned
Labels
A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arkpar @coveralls @rphmeier @gavofyork