reverse call data decoding given transaction data & method #2312
Conversation
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
jacogr
added
A0-pleasereview 🤓
jacogr
changed the title
| const CREATE_METHOD = '60606040'; | ||
|
|
||
| export function decodeCallData (data) { | ||
| if (!data || !data.length) { |
There was a problem hiding this comment.
I'd let it fail/throw here actually, to encourage consumers of this function to use it properly.
There was a problem hiding this comment.
+1 (Actually does do so later on when no signature + data, removed)
| export function decodeMethodInput (methodAbi, paramdata) { | ||
| if (!methodAbi) { | ||
| throw new Error('decodeMethodInput should receive valid method-specific ABI'); | ||
| } else if (!paramdata) { |
There was a problem hiding this comment.
Those checks don't have an AND relation, so it should be else if -> if. Every single failed check is a reason for decodeMethodInput to fail, but multiple can fail at once.
I that with throw, it doesn't make a big difference, but it's more robust.
| } | ||
|
|
||
| // takes a method in form name(..., types) and returns the interred abi definition | ||
| export function methodToAbi (method) { |
There was a problem hiding this comment.
The indexOf feels too brittle. This function should validate the syntax of method properly (right now, it will already give a false positive with spaces inside method).
If this is a standard format, as @jacogr told me, there should be an independent module for validating!
There was a problem hiding this comment.
Type checking to be done, as discussed.
api.util.* -
Allows decoding of values for https://github.com/ethcore/parity/issues/2208 & https://github.com/ethcore/parity/issues/2280