This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Reorder transaction_by_hash to favour canon search #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
reviewed
Sep 26, 2016
| .or_else(|| miner.transaction(&hash).map(Transaction::from)); | ||
| match maybe_tx { | ||
| Some(t) => to_value(&t), | ||
| None => Ok(Value::Null), |
There was a problem hiding this comment.
rob recently changed function signatures. This code won't compile.
shorter version of this function:
let miner = take_weak!(self.miner);
match try!(self.transaction(&hash)) {
None => Ok(miner.transaction(&hash).map(Into::into))
tx => tx
}There was a problem hiding this comment.
not quite (hash is still RpcH256, not H256). latest patch fixes.
debris
added
A4-gotissues 💥
gavofyork
added
A0-pleasereview 🤓
debris
added
A8-looksgood 🦄
jacogr
added a commit
that referenced
this pull request
Sep 29, 2016
* master: Fixing Delegate Call in JIT (#2378) Prioritizing re-imported transactions (#2372) Revert #2172, pretty much. (#2387) correct sync memory usage calculation (#2385) Update gitlab-ci Fix the traceAddress field in transaction traces. (#2373) Removing extras data from retracted blocks. (#2375) fixed #2263, geth keys with ciphertext shorter than 32 bytes (#2318) Expanse compatibility (#2369) Specify column cache sizes explicitly; default fallback of 2MB (#2358) Canonical state cache (master) (#2311) make block queue into a more generic verification queue and fix block heap size calculation (#2095) Hash Content RPC method (#2355) Reorder transaction_by_hash to favour canon search (#2332) DIV optimization (#2327) Error when deserializing invalid hex (#2339) Changed http:// to https:// on some links (#2349) add a test fix migration system, better errors # Conflicts: # .gitlab-ci.yml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.