Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

fix migration system for post-consolidation migrations, better errors #2334

Merged
merged 2 commits into from
Sep 28, 2016

Conversation

rphmeier
Copy link
Contributor

No description provided.

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Sep 26, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 85.21% when pulling b8b3f06 on fix-migrations into 92451ef on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 85.206% when pulling b8b3f06 on fix-migrations into 92451ef on master.

@NikVolf
Copy link
Contributor

NikVolf commented Sep 28, 2016

Can you provide an example of a problem supposed to be solved by introducing this change?

@rphmeier
Copy link
Contributor Author

sure! before the post-consolidation migrations, there are 5 columns in the database and we start with version 9. The earliest migration the manager can have within it is version 10, which means that the old no_of_columns_at function would always return None and opening the database would fail.

This solves that problem by finding the number of columns before the migrations by asking the first migration how many columns it expects the database to have before it is put into effect.

@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 28, 2016
@NikVolf NikVolf merged commit 6df1c3d into master Sep 28, 2016
@rphmeier rphmeier deleted the fix-migrations branch September 28, 2016 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants