This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Better EVM informant & Slow transactions warning #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
reviewed
Oct 3, 2016
| let time = self.last_instruction.elapsed(); | ||
| self.last_instruction = Instant::now(); | ||
|
|
||
| println!("{}[0x{:<3x}][{:>19}(0x{:<2x}) Gas Left: {:6?} (Previous took: {:10}μs)", |
There was a problem hiding this comment.
logging macros here? or is it only meant for tests?
There was a problem hiding this comment.
Not only for tests, but it's a pain to initialize logger in tests. I've made another feature to use println's.
gavofyork
added
A8-looksgood 🦄
|
shame there isn't |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second:
Additional compilation feature to print warning on slow transactions in blocks.