This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add the new EIP150 test. #2563
Merged
Add the new EIP150 test. #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any word on why they removed the delegateCall test? Seems like it would still be useful. |
gavofyork
added
A3-inprogress ⏳
|
It was moved to homestead tests actually, there are also a few new ones that should be added. Will make a PR against master. |
|
What I meant its that its already there for homestead: https://github.com/ethcore/parity/blob/gas-fix-hf/ethcore/src/json_tests/homestead_state.rs#L27 since that was homestead opcode. |
gavofyork
added a commit
that referenced
this pull request
Oct 15, 2016
* EIP150.1b first part. * Add documentation. [ci:skip] * Tweak comment * Fix some tests. * Fix create * Add the new EIP150 test. (#2563) * Fix create some more. * Another fix for create. * Final fixes. * Enable EIP150 test. * Revert the costly suicides to respect EIP150.1b. * Fixups for EIP150.1c * Update tests. * Updating tests * Adding state tests * Updating tests * Updating HF block * Removing flushln [ci:skip] * Commenting out suicide test * New tests. * Switch to EIP tests. * Rename some stuff, combine transition tests. * Fix U256 overflows. * Name cleanups and an effort to fix tests. * Rename back for clarity. * Fix non-EIP-150 OOG CALLs * New transition block number & additional EIP150 tests * Morden transition block set; Tests updated * Added missing test
tomusdrw
pushed a commit
that referenced
this pull request
Oct 18, 2016
* EIP150.1b first part. * Add documentation. [ci:skip] * Tweak comment * Fix some tests. * Fix create * Add the new EIP150 test. (#2563) * Fix create some more. * Another fix for create. * Final fixes. * Enable EIP150 test. * Revert the costly suicides to respect EIP150.1b. * Fixups for EIP150.1c * Update tests. * Updating tests * Adding state tests * Updating tests * Updating HF block * Removing flushln [ci:skip] * Commenting out suicide test * New tests. * Switch to EIP tests. * Rename some stuff, combine transition tests. * Fix U256 overflows. * Name cleanups and an effort to fix tests. * Rename back for clarity. * Fix non-EIP-150 OOG CALLs * New transition block number & additional EIP150 tests * Morden transition block set; Tests updated * Added missing test Conflicts: ethcore/res/ethereum/tests ethcore/src/json_tests/homestead_chain.rs ethcore/src/json_tests/state.rs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StateTests/stDelegatecallTestwas removed fromethereum/testssuite.