Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[frontport] CLI to specify queue ordering strategy (#2494) #2623

Merged
merged 2 commits into from
Oct 15, 2016
Merged

[frontport] CLI to specify queue ordering strategy (#2494) #2623

merged 2 commits into from
Oct 15, 2016

Conversation

tomusdrw
Copy link
Collaborator

  • gas factor ordering
  • Lowering queue size limit back to 1024

@tomusdrw
CLI to specify queue ordering strategy (#2494)
e47752c 
* Alter gas priorities to include gas_price also

* CLI options and tests

* Adding ordering by gas

* whitespace

Conflicts:
	ethcore/src/miner/miner.rs
	ethcore/src/miner/mod.rs
	ethcore/src/miner/transaction_queue.rs
	parity/cli/usage.txt
	parity/configuration.rs
@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 14, 2016
@keorn
Copy link

keorn commented Oct 15, 2016 •
edited
Loading

Build failing

@keorn keorn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 15, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 86.628% when pulling 844edc1 on tx-queue-strategy into 4581469 on master.

@keorn keorn added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Oct 15, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 15, 2016
@gavofyork gavofyork merged commit cceca91 into master Oct 15, 2016
@gavofyork gavofyork deleted the tx-queue-strategy branch October 15, 2016 12:46
@tomusdrw tomusdrw mentioned this pull request Oct 17, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomusdrw @keorn @coveralls @gavofyork