Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Styling in FF is not 100% #2669

Merged
merged 2 commits into from
Oct 17, 2016
Merged

Styling in FF is not 100% #2669

merged 2 commits into from
Oct 17, 2016

Conversation

derhuerst
Copy link
Contributor

This PR addresses #2240.

@parity-cla-bot
Copy link

It looks like this contributor signed our Contributor License Agreement. 👍

Many thanks,

Ethcore CLA Bot

@derhuerst derhuerst added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M5-ui labels Oct 17, 2016
@derhuerst
Copy link
Contributor Author

Sorry, the ParityBackground doesn't really belong into this PR. Nevertheless, it's a cheap optimisation and has no visual impact.

Regarding the spaces/lines in the TabBar: This is really weird and part of a series of bugs related to increasing the font size (try resizing in chrome). I'm not sure if it's actually possible to fix them. So this is it for now.

@derhuerst derhuerst added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Oct 17, 2016
@jacogr
Copy link
Contributor

jacogr commented Oct 17, 2016

Nice! LG.

@jacogr jacogr merged commit 12b115b into js Oct 17, 2016
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 17, 2016
@jacogr jacogr deleted the signer-fix-txhash branch October 17, 2016 20:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derhuerst @parity-cla-bot @jacogr