This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixing --no-default-features again and evmbin #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
|
Changes Unknown when pulling ed586d1 on fixes into * on master*. |
rphmeier
reviewed
Oct 17, 2016
| time: Duration, | ||
| }, | ||
| /// Error | ||
| Error { |
There was a problem hiding this comment.
Should be Err for parallel to Result.
And the type should be called ExecutionResult. Then it could just be type ExecutionResult = Result<Success, Failure> with type definitions for the enum struct variants.
There was a problem hiding this comment.
Good point. Will fix this, thanks!
tomusdrw
added
the
A3-inprogress ⏳
tomusdrw
removed
the
A3-inprogress ⏳
|
Changes Unknown when pulling 1877d12 on fixes into * on master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.