This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
refactor signer components #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
jacogr
added
A3-inprogress ⏳
|
Added A1-inprogress, need some work from my side to review the Sign stuff. Looks good by eyeballing it, just want to make 100% (and as per your validation request) |
|
Got the signer popping up, however all hell breaks loose - no doubt not caused by this PR, but rather because there is an issue that slipped in along the way. Layout is completely broken. We will need to address in this as well to get it back up to scratch. Update: https://github.com/ethcore/parity/issues/2704 |
jacogr
added
A8-looksgood 🦄
|
@jacogr merged this because we're moving the JS codebase. Will branch off again after that and fix the signer. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #2687.
@jacogr Could you please check if the sign requests work properly?