This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keorn
added
A0-pleasereview 🤓
Pull request needs code review.
M4-core ⛓
Core client code / Rust.
labels
Oct 18, 2016
Changes Unknown when pulling 71281cc on eth-syncing into * on master*. |
RPC test is failing. Looks good apart from that. |
tomusdrw
added
A5-grumble 🔥
Pull request has minor issues that must be addressed before merging.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Oct 19, 2016
gavofyork
added
A7-looksgoodtestsfail 🤖
Pull request is reviewed well, but cannot be merged due to tests failing.
and removed
A5-grumble 🔥
Pull request has minor issues that must be addressed before merging.
labels
Oct 19, 2016
keorn
added
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
and removed
A7-looksgoodtestsfail 🤖
Pull request is reviewed well, but cannot be merged due to tests failing.
labels
Oct 19, 2016
keorn
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
labels
Oct 19, 2016
Closed
gavofyork
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Oct 19, 2016
This does not seem right to me. Block queue can still have a few thousand blocks to process after the |
In this case isn't it |
No, the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #2639.
Tested on two nodes in various sync conditions (early, mid, import), it is reliable when repeatedly querying RPC. Still returns
false
for a few seconds of initial sync, but thats rather unavoidable.Should also improve situations similar to the attack when lots of uncles were increasing queue size, possibly leading to "Syncing" console output.
Its not used for mission critical stuff so block delay can be adjusted later (4 behind now).