Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Making Trie.iter non-recursive #2733

Merged
merged 1 commit into from
Oct 20, 2016
Merged

Making Trie.iter non-recursive #2733

merged 1 commit into from
Oct 20, 2016

Conversation

tomusdrw
Copy link
Collaborator

Giving about 10% boost in this simple benchmark.
I supposed that this tail-recursion was unwinded by compiler anyway.

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 19, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0005%) to 86.258% when pulling 9554791 on trie into b039323 on master.

@gavofyork
Copy link
Contributor

are there tests for the iter?

@rphmeier
Copy link
Contributor

Yes, and it's also tested by-proxy in a few places in the codebase, the snapshot tests in particular.

@gavofyork gavofyork merged commit 0017a43 into master Oct 20, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 20, 2016
@gavofyork gavofyork deleted the trie branch October 20, 2016 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomusdrw @coveralls @gavofyork @rphmeier