Make address selection searchable #2739
Conversation
| @@ -75,6 +93,13 @@ class InputAddress extends Component { | |||
| </div> | |||
| ); | |||
| } | |||
|
|
|||
| handleInputChange = (event, value) => { | |||
| let isEmpty = (value.length === 0); | |||
There was a problem hiding this comment.
Right, still some sticking old habits...
| } | ||
|
|
||
| onFocus = () => { | ||
| this.props.onChange(null, ''); |
There was a problem hiding this comment.
Throw-away comment, i.e. not for the PR. Think we probably need to re-work the event handlers in a future generation to always only return the value everywhere. Currently it is a bit of a mix, some are value, some are event & value, some are event, index & value. (And event is never handled in the React components, always only in the inputs).
There was a problem hiding this comment.
Yep, agreed. event should be only within Inputs wrappers
| { this.renderSelectEntries() } | ||
| </Select> | ||
| <div> | ||
| <AutoComplete |
There was a problem hiding this comment.
Could we (for the sake of consistency in the input components), add the AutoComplete to where we have the other input components, i.e. a thin wrapper. It feels like the odd man out atm.
There was a problem hiding this comment.
Oh yes that's right. That's what I initially planned, but forgot... Will do!
|
Small comments, minor issues. Fix and we can push it in. |
ngotchac
added
A3-inprogress ⏳
ngotchac
added
A0-pleasereview 🤓
jacogr
added
A8-looksgood 🦄
Fixes #2141
Implements address selection in transaction modal with an autocomplete, so they can be searched through...
See it in action : https://youtu.be/C-xgoemIs7c