Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixing small files fetching #2742

Merged
merged 4 commits into from
Oct 20, 2016
Merged

Fixing small files fetching #2742

merged 4 commits into from
Oct 20, 2016

Conversation

tomusdrw
Copy link
Collaborator

Last chunk could remain unflushed - forcing flush when all chunks from response are read
Also:

  1. Adding User-Agent out of courtesy
  2. Returning an error on non-200 response.

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 19, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 86.239% when pulling b629520 on https-fetch into 3b8247b on master.

@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 20, 2016
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Oct 20, 2016
@jacogr
Copy link
Contributor

jacogr commented Oct 20, 2016

Works as expected now, small files no more an issue.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 20, 2016
@gavofyork gavofyork merged commit cd4e21e into master Oct 20, 2016
@gavofyork gavofyork deleted the https-fetch branch October 20, 2016 10:57
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 86.236% when pulling 7659e64 on https-fetch into 20e1d57 on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants