Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

fix Signer UI #2750

Merged
merged 3 commits into from
Oct 22, 2016
Merged

fix Signer UI #2750

merged 3 commits into from
Oct 22, 2016

Conversation

derhuerst
Copy link
Contributor

@derhuerst derhuerst commented Oct 20, 2016

This PR solves #2704 in the most minimal way: I removed unnecessary CSS, which visually distorted the UI.

The code is still very complex and the styles very brittle, but it is usable again. As the signer will get a lot more features in the next release, a rewrite of some of the components, if not all, will be necessary.

Please check if it is usable for transaction & sign requests, both pending & finished.

edit: Contract deployment requests are broken, addressed in #2759.

@derhuerst derhuerst added A0-pleasereview 🤓 Pull request needs code review. M5-ui A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 20, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 86.228% when pulling 9a5032c on fix-signer into d2e4baf on master.

@derhuerst derhuerst added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Oct 20, 2016
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels Oct 20, 2016
@jacogr
Copy link
Contributor

jacogr commented Oct 20, 2016

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Oct 22, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 86.096% when pulling f8a0f28 on fix-signer into a1266fc on master.

@jacogr jacogr merged commit bf827a7 into master Oct 22, 2016
@jacogr jacogr deleted the fix-signer branch October 22, 2016 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants