Trace filtering fix #2760
Trace filtering fix #2760
Conversation
Don't test contract address against empty array in trace filtering
ngotchac
added
A0-pleasereview 🤓
| @@ -127,7 +132,7 @@ impl Filter { | |||
| }; | |||
|
|
|||
| action || match trace.result { | |||
| Res::Create(ref create) => self.to_address.matches(&create.address), | |||
| Res::Create(ref create) => self.to_address.stricly_matches(&create.address), | |||
There was a problem hiding this comment.
Couldn't we replace L124 with self.to_address.matches(&create.address) and remove this ||? (strictly_matches would not be required at all)
There was a problem hiding this comment.
Yes that would be totally equivalent.
There was a problem hiding this comment.
However the address field is in the result part of the trace, not in the action
tomusdrw
added
A5-grumble 🔥
| self.matches_all() || self.list.contains(address) | ||
| } | ||
| self.matches_all() || self.stricly_matches(address) | ||
| } |
There was a problem hiding this comment.
actually the issue here is that this whole line is using spaces instead of tabs for indentation.
| } | ||
|
|
||
| /// Returns true if address matches at least one of the searched addresses. | ||
| pub fn stricly_matches(&self, address: &Address) -> bool { |
rphmeier
added
A8-looksgood 🦄
ngotchac
added
A3-inprogress ⏳
ngotchac
added
A0-pleasereview 🤓
| Action::Call(ref call) => { | ||
| let from_matches = self.from_address.matches(&call.from); | ||
| let to_matches = self.to_address.matches(&call.to); | ||
| from_matches && to_matches | ||
| } | ||
| Action::Create(ref create) => { | ||
| let from_matches = self.from_address.matches(&create.from); | ||
| let to_matches = self.to_address.matches_all(); | ||
|
|
||
| let to_matches = match trace.result { |
There was a problem hiding this comment.
Hmm, now that I saw it's coming from result I'm not sure if it's equivalent.
@debris is it possible that trace.action is Action::Call but the result is Res::Create somehow?
There was a problem hiding this comment.
No. To be honest, there should be just one enum. Having two is just a performance workaround to avoid unnecessary copying data when trace is created.
tomusdrw
added
A8-looksgood 🦄
Fixes #2751
Don't test contract address against empty
toAddressarray in trace filtering.