This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Use trace API for decentralized transaction list #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
added
A5-grumble 🔥
jacogr
reviewed
Oct 21, 2016
| @@ -54,6 +54,16 @@ export default class Status { | |||
| .catch(() => dispatch(false)); | |||
| } | |||
|
|
|||
| _pollTraceMode = () => { | |||
| return this._api.trace.block() | |||
| .then(blockTraces => { | |||
There was a problem hiding this comment.
Currently miners mine 0 tx's in a block on purpose, not sure this is correct...
| }); | ||
| return (transactions || []) | ||
| .sort((tA, tB) => { | ||
| return tB.blockNumber - tA.blockNumber; |
There was a problem hiding this comment.
Does this work? All are BigNumbers. BigNumber however has a sort compare.
|
Changes Unknown when pulling 1b5945b on ng-decentralized-txs into * on master*. |
jacogr
added
A8-looksgood 🦄
|
A couple of questions:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2148
This pulls the transaction list of an account from the Trace API if available instead of Etherscan.
The availability of the Trace API is determined as follows :
trace_blockrequest to get the traces of thelatestblockThis should be ok since there aren't that many blocks with no transactions. But it would be worth finding a better solution...