Trigger accounts/contracts search on search input change #2838

ngotchac · 2016-10-24T10:06:30Z

Triggers the search in the Accounts/Contracts list views whenever the input changes
Adds a new token to the search with enter, space and comma
Re-styling of the search tokens

coveralls · 2016-10-24T10:43:41Z

Coverage decreased (-0.03%) to 86.169% when pulling 957b834 on ng-search-input-trigger into 8cf9934 on master.

derhuerst · 2016-10-24T10:56:38Z

js/src/ui/Actionbar/Search/search.css

@@ -27,6 +27,18 @@
  width: 500px !important;
 }



For reference purposes: TeamWertarbyte/material-ui-chip-input#20 may be relevant.

Right. In fact it's implemented, but not in the docs...

derhuerst · 2016-10-24T11:01:25Z

js/src/ui/Actionbar/Search/search.js

@@ -125,54 +125,56 @@ export default class ActionbarSearch extends Component {
  handleTokenAdd = (value) => {
    const { tokens } = this.props;

-    const newSearchValues = uniq([].concat(tokens, value));
+    const newSearchTokens = uniq([].concat(tokens, value));


tokens.concat(value)?

That's just in case tokens isn't really an Array, but I guess that's taken care of by the PropTypes Object

derhuerst · 2016-10-24T11:03:45Z

js/src/ui/Actionbar/Search/search.js

  }

  handleTokenDelete = (value) => {
    const { tokens } = this.props;

-    const newSearchValues = []
+    const newSearchTokens = []
      .concat(tokens)
      .filter(v => v !== value);


newSearchTokens = tokens.filter((v) => v !== value)

Same as above

derhuerst · 2016-10-24T11:05:15Z

js/src/views/Accounts/accounts.js

-    const newSearchValues = uniq([].concat(searchValues, token));
-    this.setState({ searchValues: newSearchValues });
+    const { searchTokens } = this.state;
+    const newSearchTokens = uniq([].concat(searchTokens, token));


searchValues.concat(token)?

derhuerst · 2016-10-24T11:05:37Z

js/src/views/Addresses/addresses.js

-    const newSearchValues = uniq([].concat(searchValues, token));
-    this.setState({ searchValues: newSearchValues });
+    const { searchTokens } = this.state;
+    const newSearchTokens = uniq([].concat(searchTokens, token));


searchValues.concat(token)?

derhuerst · 2016-10-24T11:05:45Z

js/src/views/Contracts/contracts.js

-    const newSearchValues = uniq([].concat(searchValues, token));
-    this.setState({ searchValues: newSearchValues });
+    const { searchTokens } = this.state;
+    const newSearchTokens = uniq([].concat(searchTokens, token));


searchValues.concat(token)?

derhuerst · 2016-10-24T11:08:07Z

js/src/ui/Actionbar/Search/search.js

+
+    const newSearchTokens = []
+      .concat(searchTokens || tokens)
+      .filter(v => v.length > 0);


newSearchTokens = (searchTokens || tokens).filter(v => v.length > 0)?

derhuerst · 2016-10-24T11:10:51Z

The behaviour (not having to press <Enter>) should be the same when adding tags in the "edit account" modal.

coveralls · 2016-10-24T13:32:41Z

Coverage decreased (-0.02%) to 86.178% when pulling bc3319e on ng-search-input-trigger into 8cf9934 on master.

coveralls · 2016-10-24T13:43:44Z

Coverage decreased (-0.05%) to 86.148% when pulling bc3319e on ng-search-input-trigger into 8cf9934 on master.

ngotchac added 5 commits October 21, 2016 17:30

Styling Chips in search bar (#2766)

e522ac2

Styling search chips // Add chip on space/comma/... (#2766)

f44f0a3

Update search on input (#2766)

5ae25d5

Fixing search triggers bugs (#2766)

78f234f

removed console logs

957b834

ngotchac added A0-pleasereview 🤓 Pull request needs code review. M5-ui labels Oct 24, 2016

derhuerst reviewed Oct 24, 2016

View reviewed changes

derhuerst added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 24, 2016

ngotchac added 2 commits October 24, 2016 13:31

Use props instead of weird CSS selectors for Search Bar

4ae357d

Add tags on space and commas in EditMeta modal (#2766)

cbd8df8

ngotchac added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Oct 24, 2016

Fixed empty input in EditMeta modal ; tokens input

bc3319e

derhuerst added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 24, 2016

gavofyork merged commit 487da9c into master Oct 24, 2016

gavofyork deleted the ng-search-input-trigger branch October 24, 2016 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trigger accounts/contracts search on search input change #2838

Trigger accounts/contracts search on search input change #2838

ngotchac commented Oct 24, 2016

coveralls commented Oct 24, 2016

derhuerst Oct 24, 2016

ngotchac Oct 24, 2016

derhuerst Oct 24, 2016

ngotchac Oct 24, 2016

derhuerst Oct 24, 2016

ngotchac Oct 24, 2016

derhuerst Oct 24, 2016

derhuerst Oct 24, 2016

derhuerst Oct 24, 2016

derhuerst Oct 24, 2016

derhuerst commented Oct 24, 2016

coveralls commented Oct 24, 2016

coveralls commented Oct 24, 2016

Trigger accounts/contracts search on search input change #2838

Trigger accounts/contracts search on search input change #2838

Conversation

ngotchac commented Oct 24, 2016

coveralls commented Oct 24, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derhuerst commented Oct 24, 2016

coveralls commented Oct 24, 2016

coveralls commented Oct 24, 2016