Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixes currency symbol font size in Shapeshift modal #2840

Merged
merged 3 commits into from
Oct 24, 2016

Conversation

ngotchac
Copy link
Contributor

Fixes #2718
Small text and space on the left.

parity - shapeshit curr

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M5-ui labels Oct 24, 2016
.symbol {
font-variant: small-caps;
margin-left: 0.1rem;
font-size: 0.7rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should preferably be a percentage of the parent (e.g. 70%). By doing this, you can easily change the font size of the parent without breaking the font size of .symbol.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I guess em should do the trick. Will fix

@derhuerst derhuerst added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 24, 2016
@derhuerst derhuerst added A8-looksgood 🦄 Pull request is reviewed well. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Oct 24, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 86.148% when pulling 90dcade on ng-shapeshift-exchange-rate into 66a8d53 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 86.182% when pulling 90dcade on ng-shapeshift-exchange-rate into 66a8d53 on master.

@gavofyork gavofyork merged commit f4203a2 into master Oct 24, 2016
@gavofyork gavofyork deleted the ng-shapeshift-exchange-rate branch October 24, 2016 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants