Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Sweep some more panics #2848

Merged
merged 3 commits into from
Oct 25, 2016
Merged

Sweep some more panics #2848

merged 3 commits into from
Oct 25, 2016

Conversation

rphmeier
Copy link
Contributor

No description provided.

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 24, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 24, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 86.149% when pulling 3e7110b on purge-unwraps into edbd667 on master.

@gavofyork
Copy link
Contributor

gitlab fails, but everything else succeeds? wtf?

@rphmeier
Copy link
Contributor Author

rphmeier commented Oct 25, 2016

@gavofyork gitlab appears to be checking out my PR based on a master before #2846.
@General-Beck is it possible to have gitlab update the merge head on rebuild/update?

@rphmeier rphmeier closed this Oct 25, 2016
@rphmeier rphmeier reopened this Oct 25, 2016
@gavofyork
Copy link
Contributor

gitlab still borked?

@rphmeier
Copy link
Contributor Author

rphmeier commented Oct 25, 2016

unsure, reopened to see if it'll update the merge head. if not, I would still say this is 100% safe to merge.

CI is guidance, not an authority. in this case gitlab appears to be misguiding us :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 86.128% when pulling 3e7110b on purge-unwraps into edbd667 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 86.135% when pulling 1a7d46c on purge-unwraps into 7eacf07 on master.

@gavofyork gavofyork merged commit 33748c2 into master Oct 25, 2016
@gavofyork gavofyork deleted the purge-unwraps branch October 25, 2016 20:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants