Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Nicer port in use errors #2859

Merged
merged 6 commits into from
Oct 25, 2016
Merged

Nicer port in use errors #2859

merged 6 commits into from
Oct 25, 2016

Conversation

keorn
Copy link

@keorn keorn commented Oct 25, 2016

No description provided.

@keorn keorn added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 25, 2016
@tomusdrw
Copy link
Collaborator

I think I would add something like: make sure that another instance of Parity or geth is not running or specify different port using:

@tomusdrw
Copy link
Collaborator

And would be good if there was a similar message for Signer and Network too :)

@keorn
Copy link
Author

keorn commented Oct 25, 2016

It is fine to run another Parity instance, it just has to use different resources.

@keorn keorn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 25, 2016
@tomusdrw
Copy link
Collaborator

Yes, but it suggests to non tech-savvy users what (may have) caused the problem.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 86.136% when pulling 4f2f0cd on nicer-port-errors into b6f2628 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 86.153% when pulling c9037be on nicer-port-errors into b6f2628 on master.

@keorn keorn closed this Oct 25, 2016
@keorn keorn reopened this Oct 25, 2016
@keorn keorn added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Oct 25, 2016
@keorn keorn changed the title Nicer dapps and rpc port in use errors Nicer port in use errors Oct 25, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 86.136% when pulling 921b500 on nicer-port-errors into b6f2628 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 86.106% when pulling 921b500 on nicer-port-errors into b6f2628 on master.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 25, 2016
@gavofyork gavofyork merged commit 8d0cff3 into master Oct 25, 2016
@gavofyork gavofyork deleted the nicer-port-errors branch October 25, 2016 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants