Add inject to "bundle everything" list #2871
Conversation
|
Ok so I removed the Webpack DLL (used in dev) in production builds, this should do the trick.
|
| @@ -41,7 +41,6 @@ module.exports = { | |||
| 'signaturereg': ['./dapps/signaturereg.js'], | |||
| 'tokenreg': ['./dapps/tokenreg.js'], | |||
| // library | |||
| 'inject': ['./inject.js'], | |||
| 'parity': ['./parity.js'], | |||
There was a problem hiding this comment.
Remove parity.js as well?
There was a problem hiding this comment.
This is useful for the Webpack CommonChunks usage, so it separates parity.js changes from the others (better perf. I think)
| name: 'commons' | ||
| }) | ||
| ); | ||
| plugins.push( | ||
| new webpack.optimize.CommonsChunkPlugin({ | ||
| chunks: [ 'parity' ], | ||
| chunks: ['parity'], |
There was a problem hiding this comment.
As here - web3/inject & parity should be treated the same.
| @@ -1,4 +1,4 @@ | |||
| { | |||
| { | |||
There was a problem hiding this comment.
These 2 spaces look suspicious :)
| @@ -7,6 +7,6 @@ | |||
| <title>dev::Web3</title> | |||
| </head> | |||
| <body> | |||
| <script src="inject.js"></script> | |||
| <script src="web3.js"></script> | |||
There was a problem hiding this comment.
Can we make this /parity-utils/web.js (same with /parity-utils/parity.js in dev.html and for dapp.html as well.)
jacogr
added
A8-looksgood 🦄
Getting the following issues while trying to replicate (https://github.com/ethcore/parity/issues/2868 - at this point getting a diefferent issue, not the one listed, but it still doesn't work) -
Obviously
inject.js(injecting web3) likeparity.jsshould not need the vendor stuff. (I have seen this internally as well.)@ngotchac Could you take a look to make sure my approach here is right from a build prespective?
Fixes #2872