Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Allow operation when no registry is available #2980

Merged
merged 5 commits into from
Oct 31, 2016
Merged

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Oct 29, 2016

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M5-ui labels Oct 29, 2016
@ngotchac
Copy link
Contributor

There seems to be some errors when there is no Registry contract address (_retrieveTokens Error: -32602: Invalid params or Error: -32602: Invalid params(…) in ws.js). I guess some part of the app is not checking if there is actually a registry deployed.

It also seems that my local dApp which doesn't uses the registry isn't displayed/accessible.

@ngotchac ngotchac added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 31, 2016
@jacogr
Copy link
Contributor Author

jacogr commented Oct 31, 2016

Ok, the local dapp should definitely show, that needs to be addressed - only builtins should be removed.

The intent was not to remove the actual check from all places, just made sure that when they fail, they are ignored. (There are a number of combinations when done properly, no Registry, Registry but no TokenReg, etc.)

@jacogr
Copy link
Contributor Author

jacogr commented Oct 31, 2016

As discussed & shown, cannot replicate the dapps issue. Others issues not for this release, could do it straight-after.

@ngotchac
Copy link
Contributor

My bad, it is working...

@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Oct 31, 2016
@gavofyork gavofyork merged commit ea784d7 into master Oct 31, 2016
@gavofyork gavofyork deleted the jg-allow-no-registry branch October 31, 2016 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants