This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixes pending/mined transactions in registry dApp #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Oct 31, 2016
| @@ -49,7 +49,9 @@ export default class Accounts extends Component { | |||
| value={ selected ? this.renderAccount(selected) : null } | |||
| onChange={ this.onAccountSelect } | |||
| iconButtonElement={ accountsButton } | |||
| animated={ false } | |||
|
|
|||
| anchorOrigin={ { horizontal: 'right', vertical: 'top' } } | |||
There was a problem hiding this comment.
Could we make this a constant, i.e.
const origin = { horizontal: 'right, vertical: 'top' };
...
<SomeTag
anchorOrigin={ origin }
targetOrigin={ origin }
|
One small comment, but apart from that, ok. |
jacogr
added
A8-looksgood 🦄
|
Changes Unknown when pulling 3d14d0f on ng-registry-double-tx into * on master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2930
Also fixes some small React errors popping out