Update Parity logo #3036
Update Parity logo #3036
Conversation
jacogr
added
A3-inprogress ⏳
|
It would be possible to inline the SVG and hide/show text & customise colours using CSS. |
jacogr
added
A0-pleasereview 🤓
|
Changes Unknown when pulling 3d703ea on jg-parity-logo into * on master*. |
|
Changes Unknown when pulling 3d703ea on jg-parity-logo into * on master*. |
|
Changes Unknown when pulling 3d703ea on jg-parity-logo into * on master*. |
| @@ -87,7 +87,7 @@ module.exports = { | |||
| loader: 'file-loader' | |||
| }, | |||
| { | |||
| test: /\.ico$/, | |||
| test: /parity-logo-black-no-text\.png$/, | |||
There was a problem hiding this comment.
Isn't this redundant with the test: /\.(png|jpg)$/ above ?
There was a problem hiding this comment.
The reason for this one - we want the filename preserved in the copy. (Otherwise it ends up using the MD5 value as the filename and we cannot pull it in from the HTML - which is obviously not desirable if you want to use it is a favicon)
There was a problem hiding this comment.
Ok, fair enough, but we could actually stick to the name.extension format for other images, or I think pass an argument while importing the image in the JS
# Conflicts: # js/package.json
|
Changes Unknown when pulling 876eb39 on jg-parity-logo into * on master*. |
|
Changes Unknown when pulling 13865b9 on jg-parity-logo into * on master*. |
ngotchac
added
A8-looksgood 🦄
Closes https://github.com/ethcore/parity/issues/3033