Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Warp sync status display #3045

Merged
merged 2 commits into from
Nov 1, 2016
Merged

Warp sync status display #3045

merged 2 commits into from
Nov 1, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Nov 1, 2016

Closes https://github.com/ethcore/parity/issues/3040 - the first-generation. Second generation will have to be graphical.

parity 2016-11-01 11-51-09

parity 2016-11-01 11-55-24

parity 2016-11-01 11-56-48

Sadly, the eth_syncing doesn't return the historic information when we are not syncing. (i.e. 3rd image above, historic blocks are still being downloaded we have no access to that status) Think when we move the namespace of this we should change it in conjunction with a proper graphical display

@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M6-ui labels Nov 1, 2016
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 1, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9a02f1d on jg-sync-status into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9a02f1d on jg-sync-status into * on master*.

@gavofyork
Copy link
Contributor

@rphmeier / @arkpar can we get information on the historical blocks download?

@jacogr
Copy link
Contributor Author

jacogr commented Nov 1, 2016

@gavofyork Discussed it with @rphmeier earlier today - we will need to create an RPC, but certainly do-able. Logged it https://github.com/ethcore/parity/issues/3064

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 1, 2016
@gavofyork gavofyork merged commit efbbe50 into master Nov 1, 2016
@gavofyork gavofyork deleted the jg-sync-status branch November 1, 2016 21:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants