Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

settings: replace background patterns (inline) #3047

Merged
merged 4 commits into from
Nov 1, 2016

Conversation

derhuerst
Copy link
Contributor

#3038

I also moved the "generate more" button to the overview section on the left, letting users see immediately that there's more to chose from.

@derhuerst derhuerst added A0-pleasereview 🤓 Pull request needs code review. M6-ui labels Nov 1, 2016
@jacogr
Copy link
Contributor

jacogr commented Nov 1, 2016

  1. Doesn't preserve current (so user cannot go back)
  2. One missing

parity 2016-11-01 13-08-35

@jacogr jacogr added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 1, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a2f1935 on settings-background-patterns into * on master*.

@derhuerst derhuerst added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Nov 1, 2016
@jacogr jacogr added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 1, 2016
@jacogr
Copy link
Contributor

jacogr commented Nov 1, 2016

Preserving works after the update.

Current master:

Open page and you have your current background visible & selected

This version:

Open page and you don't have your current background available, neither is it selected

@derhuerst
Copy link
Contributor Author

Sorry, really didn't pay attention. 😞

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 558a219 on settings-background-patterns into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 558a219 on settings-background-patterns into * on master*.

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Nov 1, 2016
@jacogr jacogr merged commit 145a88d into master Nov 1, 2016
@jacogr jacogr deleted the settings-background-patterns branch November 1, 2016 17:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants