This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Allow boolean dropdowns for contract deploy #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacogr
commented
Nov 1, 2016
jacogr
commented
- Allow boolean dropdown for contract deploys, Fixes https://github.com/ethcore/parity/issues/3067
- Make uint non-hex to align with execute modal, Closes https://github.com/ethcore/parity/issues/3068
|
tested, confirmed fixed. Thanks @jacogr |
derhuerst
reviewed
Nov 2, 2016
| label={ label } | ||
| value={ params[index] ? 'true' : 'false' } | ||
| error={ paramsError[index] } | ||
| onChange={ onChangeBool }>{ boolitems }</Select> |
There was a problem hiding this comment.
multiple lines for better readability? (:
derhuerst
reviewed
Nov 2, 2016
| @@ -168,8 +188,12 @@ export default class DetailsStep extends Component { | |||
| params.push(''); | |||
| break; | |||
|
|
|||
| case 'bool': | |||
There was a problem hiding this comment.
inputs.forEach -> inputs.map
Also, I'd rename params to defaults to make it more readable. (correct me if that's wrong)
There was a problem hiding this comment.
It is parameters according the the API, so it is consistent all the way through.
ngotchac
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.