This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Load network dapps #3078
Merged
Load network dapps #3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A8-looksgood 🦄
gavofyork
reviewed
Nov 2, 2016
| @@ -38,7 +38,14 @@ export default class Summary extends Component { | |||
| return null; | |||
| } | |||
|
|
|||
| const url = `/app/${app.builtin ? 'global' : 'local'}/${app.url || app.id}`; | |||
| let type = 'builtin'; | |||
There was a problem hiding this comment.
why set it here if it will only become set to something else next?
There was a problem hiding this comment.
Erk. Actually missing the built-in type determination, this and next comment. Silly me, only tested GAVcoin, half-assed job - this is a bug. Good catch.
There was a problem hiding this comment.
Fixed. Apps in installed in .pariyt/dapps, builtins & network apps now work as expected.
gavofyork
reviewed
Nov 2, 2016
| type = 'network'; | ||
| } else { | ||
| type = 'local'; | ||
| } |
There was a problem hiding this comment.
let type = app.network ? 'network' : 'local';?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GAVcoin available on Morden only (live deployment to take place once app ok)