This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add read-only inputs to UI plus Copy to Clipboard buttons #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Nov 2, 2016
| @@ -31,7 +31,8 @@ export default class AccountDetails extends Component { | |||
| return ( | |||
| <Form> | |||
| <Input | |||
| disabled | |||
| readOnly | |||
| copiable | |||
There was a problem hiding this comment.
copyable :)
allowCopy is probably better.
jacogr
reviewed
Nov 2, 2016
| @@ -129,10 +129,12 @@ class Event extends Component { | |||
|
|
|||
| return ( | |||
| <Input | |||
| disabled | |||
| readOnly | |||
There was a problem hiding this comment.
Addresses are always copyable if disabled/readonly. Is that not right?
There was a problem hiding this comment.
Aaaahhhh... sorrry, must have had one eye closed. Perfect.
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #3066 #3052 and #3009
disabledinputs are converted toreadonlyinputs.New props can be added to
Inputcomponents to render a Copy to Clipboard button.This has been added in Contracts/Accounts/Events/Account Creation....