Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Enabling personal RPC over IPC by default #3165

Merged
merged 1 commit into from
Nov 4, 2016
Merged

Enabling personal RPC over IPC by default #3165

merged 1 commit into from
Nov 4, 2016

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Nov 4, 2016

Required by EthereumWallet/Mist
Should go before #3143 and be backported to beta.

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. B0-patch M4-core ⛓ Core client code / Rust. labels Nov 4, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 4, 2016
@gavofyork gavofyork merged commit 68f6059 into master Nov 4, 2016
@gavofyork gavofyork deleted the personal branch November 4, 2016 08:58
@gavofyork
Copy link
Contributor

might be sensible to restrict this to --geth mode?

@tomusdrw
Copy link
Collaborator Author

tomusdrw commented Nov 4, 2016

Yeah, we might do that. But I think that if you have malicious software that can access IPC socket most probably all potential attack vectors using this RPC can be performed anyway.

arkpar added a commit that referenced this pull request Nov 4, 2016
* Linux build case sensitivity fix (#3161)

* Make the footer a bit less ugly. (#3160)

* Make the footer a bit less ugly.

* Whitespace.

* Enabling personal RPC over IPC by default (#3165)

* Push precompiled for beta/stable, npm only master (#3163)

* Push precompiled for beta/stable, npm only master

* Release to npm before comitting updates

* Fixes #3171 (#3175)

* Remove extra cd js (#3177)

* Back to real root (#3178)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants