Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Remove 127.0.0.1 references #3303

Merged
merged 1 commit into from
Nov 9, 2016
Merged

Remove 127.0.0.1 references #3303

merged 1 commit into from
Nov 9, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Nov 9, 2016

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M6-ui labels Nov 9, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 9, 2016
@jacogr
Copy link
Contributor Author

jacogr commented Nov 9, 2016

To be supplemented with a new dappsInterface RPC call to retrieve the full network path from Parity. (To update dappsUrl call in API layer once available)

@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Nov 9, 2016
@jacogr
Copy link
Contributor Author

jacogr commented Nov 9, 2016

Moved to in progress so we can have one PR that fixes the full issue in one go.

@gavofyork
Copy link
Contributor

looks like work is being continued in #3311.

@gavofyork
Copy link
Contributor

will merge this and let work continue under #3311.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 9, 2016
@gavofyork gavofyork merged commit 95e03f8 into master Nov 9, 2016
@gavofyork gavofyork deleted the jg-non-127001 branch November 9, 2016 13:02
@arkpar arkpar added the B0-patch label Nov 9, 2016
arkpar pushed a commit that referenced this pull request Nov 9, 2016
arkpar pushed a commit that referenced this pull request Nov 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants