Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix panic on importing own invalid transaction #3550

Merged
merged 1 commit into from
Nov 23, 2016
Merged

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Nov 21, 2016

Caller of add_transactions_to_queue expects number of results to match the number of transactions passed.

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. B0-patch labels Nov 21, 2016
@gavofyork
Copy link
Contributor

@tomusdrw could you check this?

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 22, 2016
@tomusdrw tomusdrw merged commit a969c00 into master Nov 23, 2016
@tomusdrw tomusdrw deleted the tx-check-fix branch November 23, 2016 07:46
arkpar added a commit that referenced this pull request Nov 25, 2016
* Ropsten network (#3539)

* Ropsten network

* Sorted premine

* Comas

* Removed trailing coma

* --testnet set to ropset

* New registry contract address for ropsten (#3549)

* New registry for ropsten

* Registry address

* Registry with payable modifier

* Fix panic on importing own invalid transaction (#3550)

* Use patched MIO

* Trim whitespace from recovery phrase

* v1.4.5

* Appending logs by default

* Fixing phrases generated on windows

* Manually add \r to Windows phrases pre 1.4.4

* < 1.4.5

* Update test, fix number. (#3612)

* Set default tx price to 0.0025 USD

* Only support 1.4.x dictionary
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants