Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix local tx requests #3589

Merged
merged 4 commits into from
Nov 23, 2016
Merged

Fix local tx requests #3589

merged 4 commits into from
Nov 23, 2016

Conversation

ngotchac
Copy link
Contributor

The local tx dapp was making a lot of requests, and didn't cleaned itself up.
Webpack wasn't working for rpc calls either.

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M8-dapp 💎 Decentralized applications. labels Nov 23, 2016
@jacogr jacogr added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 23, 2016
@jacogr
Copy link
Contributor

jacogr commented Nov 23, 2016

Conflicts with new/improved webpack config

@ngotchac ngotchac added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Nov 23, 2016
@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 23, 2016
@ngotchac
Copy link
Contributor Author

Fixed Webpack config. Everything should be good now

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c053ff1 on ng-fix-ws-localtx into ** on master**.

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 23, 2016
@jacogr jacogr merged commit d429f55 into master Nov 23, 2016
@jacogr jacogr deleted the ng-fix-ws-localtx branch November 23, 2016 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M8-dapp 💎 Decentralized applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants