Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Appending logs by default #3609

Merged
merged 1 commit into from
Nov 25, 2016
Merged

Appending logs by default #3609

merged 1 commit into from
Nov 25, 2016

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Nov 25, 2016

I believe it's better for us to have the logger append by default (people will be able to provide logs after restart).
Old behaviour is simple to replicate:

$ echo "" > $LOG_FILE
$ parity --log-file $LOG_FILE

so I don't see a reason to have separate CLI option to choose the behavior.

Closes #3596

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M4-core ⛓ Core client code / Rust. labels Nov 25, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 25, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 85.936% when pulling ed7dde0 on log-append into 86522c8 on master.

@arkpar arkpar merged commit 9b9bdaa into master Nov 25, 2016
@arkpar arkpar deleted the log-append branch November 25, 2016 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants