This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
possible fix for queue drop deadlock #3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
|
Simplified the conclusion logic (as the deleting flag was shared anyway it didn't need reproducing) and no longer wait for threads to conclude. Stuck verifier threads in the future will now just lead to leaked resources rather than a full deadlock. |
rphmeier
added
A3-inprogress ⏳
|
Will take this opportunity to change how the check is done after discussion with @arkpar |
rphmeier
added
A0-pleasereview 🤓
|
Now alters the verification loop to use a state machine which should be resistant to all races. |
arkpar
reviewed
Dec 5, 2016
| self.more_to_verify.notify_all(); | ||
|
|
||
| // second pass to join. | ||
| for handle in verifiers.drain(..) { | ||
| handle.join(); |
There was a problem hiding this comment.
The queue still needs to wait for all threads to finish
arkpar
added
A4-gotissues 💥
rphmeier
added
A0-pleasereview 🤓
|
Issues addressed. |
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix in accordance with my theory in #3686 although this is the kind of thing that's very hard to test -- it's more or less at the whim of the OS scheduler :)
Wait conditions are now checked under locks and in a documented ordering.